Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

Set AvoidSystemUpdate default value to True#6

Merged
hexbyt3 merged 1 commit intohexbyt3:masterfrom
Samoth25:samoth
Nov 13, 2025
Merged

Set AvoidSystemUpdate default value to True#6
hexbyt3 merged 1 commit intohexbyt3:masterfrom
Samoth25:samoth

Conversation

@Samoth25
Copy link

@Samoth25 Samoth25 commented Nov 13, 2025 •
edited by coderabbitai bot
Loading

AvoidSystemUpdate will now default to True when the bot starts for the first time, preventing automatic system updates unless manually overridden.

Summary by CodeRabbit

Release Notes

  • Chores
    • Modified default configuration: system updates are now avoided by default. Users can explicitly enable them through settings if needed.

@coderabbitai
Copy link

coderabbitai bot commented Nov 13, 2025 •
edited
Loading

Walkthrough

The AvoidSystemUpdate property in the TimingSettings class has been assigned a default value of true. Previously uninitialized, this property now defaults to enabled unless explicitly overridden.

Changes

Cohort / File(s) Summary
Default Property Initialization
SysBot.Pokemon/Settings/Integrations/TimingSettings.cs		 Set AvoidSystemUpdate property default value to true

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single property default value assignment with no logic changes or side effects

Poem

🐰 A bunny's timings work just right,
With defaults set to dodge the blight,
No system updates in the night—
One little line, all systems bright! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: setting the default value of AvoidSystemUpdate to true in TimingSettings.cs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eec5204 and d70436c.

📒 Files selected for processing (1)
  • SysBot.Pokemon/Settings/Integrations/TimingSettings.cs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (1)
SysBot.Pokemon/Settings/Integrations/TimingSettings.cs (1)

16-16: LGTM! Change aligns with the PR objective and is safe to merge.

The default value of true for AvoidSystemUpdate makes sense from a safety perspective—it prevents system updates from interrupting bot operations by default. This is consistent across all Pokemon game executors (LGPE, BDSP, PLZA, SWSH, SV, LA) which properly check this setting to either decline updates or skip rescue protocols.

This is a behavioral change: existing installations without explicit configuration will now decline system updates by default. However, users with existing config files specifying a value will not be affected, and the code comments already document the intended behavior.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hexbyt3 hexbyt3 merged commit 7f297bb into hexbyt3:master Nov 13, 2025
3 of 4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hexbyt3 hexbyt3 hexbyt3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Samoth25 @hexbyt3